feat: support start/stop fragment marker #813
Conversation
|
PR missing one of the required labels: {'bug', 'new feature', 'dependencies', 'documentation', 'breaking-change', 'internal', 'enhancement'} |
wyfo
force-pushed
the
feat/fragment_marker
branch
from
b382a3b to
63fbb17
Compare
|
PR missing one of the required labels: {'dependencies', 'internal', 'documentation', 'enhancement', 'breaking-change', 'new feature', 'bug'} |
wyfo
force-pushed
the
feat/fragment_marker
branch
from
63fbb17 to
1f4cf1d
Compare
Co-authored-by: Alexander Bushnev <[email protected]>
Co-authored-by: Alexander Bushnev <[email protected]>
Co-authored-by: Alexander Bushnev <[email protected]>
Co-authored-by: Alexander Bushnev <[email protected]>
Co-authored-by: Alexander Bushnev <[email protected]>
Co-authored-by: Alexander Bushnev <[email protected]>
Co-authored-by: Alexander Bushnev <[email protected]>
Co-authored-by: Alexander Bushnev <[email protected]>
Co-authored-by: Alexander Bushnev <[email protected]>
Co-authored-by: Alexander Bushnev <[email protected]>
Co-authored-by: Alexander Bushnev <[email protected]>
Co-authored-by: Alexander Bushnev <[email protected]>
Co-authored-by: Alexander Bushnev <[email protected]>
Co-authored-by: Alexander Bushnev <[email protected]>
Co-authored-by: Alexander Bushnev <[email protected]>
Co-authored-by: Alexander Bushnev <[email protected]>
Co-authored-by: Alexander Bushnev <[email protected]>
Co-authored-by: Alexander Bushnev <[email protected]>
| if (_Z_HAS_FLAG(header, _Z_FLAG_T_Z)) { | ||
| ret = _Z_ERR_MESSAGE_SERIALIZATION_FAILED; | ||
| if (msg->first) { | ||
| if (_Z_HAS_FLAG(header, _Z_FLAG_T_Z) == true) { |
There was a problem hiding this comment.
Just a nit and I see there are some that precedes that PR, but all conditions should be booleans so the == true / false would be redundant and can be removed.
There was a problem hiding this comment.
See #813 (comment)
I asked before writing the code, but didn't understand Sasha's answer ^_^' (I would never have the idea to write == true if I had not seen it everywhere in the code)
There was a problem hiding this comment.
There was a problem hiding this comment.
AFAIK, MISRA-C rules about using non-boolean values as boolean expression:
e. g.
int i = 1;
if (i) {}
but this kind of expression is absolutely legal:
bool b = true;
if (b) {}
There was a problem hiding this comment.
Well, yes but I also believe it depends on the static analyser... I'm not saying we should use == true, I was just providing a bit more context :)
|
All CI is green but CI status checks which is stuck. I'm going to manual merge the PR. |
This is a known issue, @diogomatsubara is working on. |
See eclipse-zenoh/zenoh#1597